我目前正在尝试创建一个函数，用于查找字符串中最短的单词。

Question

TypeError：无法读取未定义的属性“长度”| 查找字符串中最短的单词| Codewars 挑战

2018-09-28

221

javascript

我目前正在尝试创建一个函数，用于查找字符串中最短的单词。

问题：我收到以下错误

TypeError：无法读取未定义的属性“length” at findShort at Test.describe._ at /runner/frameworks/javascript/cw-2.js:152:11 at Promise._execute at Promise._resolveFromExecutor at new Promise at Object.describe at /home/codewarrior/index.js:24:10 at /home/codewarrior/index.js:28:5 at Object.handleError

这是我的代码

findShort("turns out random test cases are easier than writing out basic ones");

function findShort(s){

  let array = s.split(" ");
  let shortestWord = array[0];
  
  for (i = 0; i < array.length; i++) {
    let str = array[i + 1];
    
    if (shortestWord.length > str.length) {
      shortestWord = str.length;
    }
    
  }
  
  return shortestWord;
}

Answer 1

我发现两个问题：

行 let str = array[i + 1] 将导致在循环的最后一次运行中出现 undefined 。这是因为在最后一次运行中， i 比数组长度小一，因此 i + 1 超出了数组范围。为了弥补这一点，请考虑将循环条件更改为 i < array.length - 1 。
其次，您将单词长度分配给 shortestWord 变量，而我认为您的意思是将单词本身分配给该变量。

考虑到这两个更改，您可以像这样修改代码：

function findShort(s) {

  let array = s.split(" ");
  let shortestWord = array[0];
  
  for (i = 0; i < array.length - 1; i++) { // -1 here to compensate for the +1 on the next line.
    let str = array[i + 1];
    
    if (shortestWord.length > str.length) {
      shortestWord = str; // Just assign the word itself to this variable, not the length of it.
    }
    
  }
  
  return shortestWord;
}

const result = findShort("turns out random test cases are easier than writing out basic ones");
console.log(result);

Answer 2

我相信这是实现您想要的更简洁的方法：

console.log(findShort("turns out random test cases are easier than writing out basic ones"));

function findShort(s){
  let input = s;
  let array = input.split(" ");
  
  var shortest = array.reduce((shortestWord, currentWord) => {
    return currentWord.length < shortestWord.length ? currentWord : shortestWord;
  }, array[0]);
  return shortest;
}

https://jsfiddle.net/02z5oyh1/